Moving to new hash syntax #7890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code itself is being changed gradually. Otherwise, we make merging branches and current pull requests very painful. Please do go ahead and update all the docs to the 1.9 syntax! 🤘 |
|
Cool. I'll pick it up on the docrails route for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for changes of comments on a base.rb file in actionpack to the new hash syntax.
Being a major code reference, I would assume the overall code base should be changed to use the 1.9 format, however not sure if this is the view of the core committers.
I'm sending this as a PR rather than using docrails to discuss that. The only existing discussion I could find is:
http://grokbase.com/t/gg/rubyonrails-core/129cp75kv2/rails-core-rails-guides-use-new-hash-syntax
If this is accepted, I can continue the progress of such migration